Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to 1.20.1 #78

Merged
merged 17 commits into from
Aug 25, 2023
Merged

Port to 1.20.1 #78

merged 17 commits into from
Aug 25, 2023

Conversation

Jab125
Copy link
Collaborator

@Jab125 Jab125 commented Aug 12, 2023

No description provided.

@XyperCode XyperCode self-requested a review August 12, 2023 15:15
Copy link
Collaborator Author

@Jab125 Jab125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick self review:

  • A few Font#draw calls were accidentally translated to GuiGraphics#drawString without shadow=false

  • RenderUtil needs major reworking in a future update, since it contains 90% legacy code. ResourceLocation in the rect drawing methods is ignored.

  • Item rendering is slightly broken.

  • Printer's text renders in the wrong location.

Most methods now take GuiGraphics instead of PoseStack.

Edit: And the fabric datagen helper fails to compile, which is why the build fails.

@Jab125 Jab125 self-assigned this Aug 13, 2023
@Jab125 Jab125 added the development Something related on development label Aug 13, 2023
@Jab125 Jab125 mentioned this pull request Aug 13, 2023
@Jab125 Jab125 linked an issue Aug 13, 2023 that may be closed by this pull request
@Jab125 Jab125 marked this pull request as ready for review August 13, 2023 08:10
@Jab125 Jab125 requested a review from a team August 14, 2023 11:22
Copy link
Member

@XyperCode XyperCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit glitchy, but it's definitely a port to 1.20.1.

@XyperCode XyperCode merged commit ef06fab into 1.20.1 Aug 25, 2023
@Jab125 Jab125 deleted the Jab125/1.20.1-port branch January 4, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Something related on development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.20.1 port
2 participants