Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seat entity despawning when block 2 blocks under is air. #105

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

Jab125
Copy link
Collaborator

@Jab125 Jab125 commented Mar 26, 2024

This also corrects the behaviour to behave like the 1.12.2 device mod.

The location of the seat block is stored in SeatEntity as blockPos, which is serialised and deserialised with the names DevicesChairX, DevicesChairY and DevicesChairZ on world save and world load respectively.

This should ship on the next 0.8.X update.

Fixes #104

@Jab125 Jab125 requested a review from XyperCode March 26, 2024 10:56
@Jab125 Jab125 self-assigned this Mar 26, 2024
Copy link
Member

@XyperCode XyperCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@Jab125 Jab125 merged commit 4335a28 into 1.20.1 Mar 28, 2024
4 checks passed
@XyperCode XyperCode added this to the Devices Mod 0.8.3 milestone Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.20.1] Office chair will instantly kick player off when placed on block 2 blocks under it is air
2 participants