Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update website #39

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Update website #39

merged 3 commits into from
Nov 20, 2023

Conversation

marwin89
Copy link
Collaborator

@marwin89 marwin89 commented Oct 30, 2023

What does this PR do?

  1. update infos and texts (see screenshots)
  2. add overview section for overview graphics,
  3. add overview graphics under images (for linking to it)
  4. improve layout
  5. make "source" a seperate section
  6. prepare a hidden "new features"-section (in case for a release)
  7. Add vocaluxe to "together-with" (cause they are basically in if they get devs)
  8. Removed "contributors" in images-folder (not needed)
  9. Fix Favicon

Closes Issue(s)

Motivation

Keep website updated, improve layout

More

website-update-deprecated
website-update-overview
website-update-sources
website-update-together-with
website-update-txt
new-features

Copy link
Collaborator

@Baklap4 Baklap4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response, got a couple of items 👍 thanks again for the update! Also the index.html has a conflict which needs to be resolved before merging :)

docs/index.html Show resolved Hide resolved
docs/index.html Outdated Show resolved Hide resolved
@marwin89 marwin89 requested a review from Baklap4 October 31, 2023 18:37
@marwin89
Copy link
Collaborator Author

@Baklap4 conflicts are resolved, review requests done 👍

@marwin89
Copy link
Collaborator Author

marwin89 commented Nov 1, 2023

Commit 6: Code Fixes

  • fixed line endings
  • checked with html validator (duplicated ids solved etc.)
  • fixed favicon - now displayed
    favicon-fixed

Baklap4
Baklap4 previously approved these changes Nov 1, 2023
Copy link
Collaborator

@Baklap4 Baklap4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but still needs to be rebased correctly

git checkout main
git pull
git checkout update-website
git rebase -i origin/main
#fix any conflicts (if conflict -> git add -A && git rebase --continue  )
git push -f # this is destructive so please make sure it's working correctly as before :)

update infos, add overview section for overview graphics, improve layout, prepare a hidden "new features"-section
linked github profiles in credits
commented when "new feature" section has to be displayed
fixed line endings
checked with html validator (duplicated ids solved etc.)
fixed favicon - now displayed
@marwin89
Copy link
Collaborator Author

marwin89 commented Nov 1, 2023

@Baklap4 can you review again?
I force-pushed (Using GitHub Desktop cause I'm unexperienced don't use terminal) hope this is right.
All files look correct, website works fine :)

@marwin89
Copy link
Collaborator Author

@Baklap4 : could you review this pr? 👋 😃

@marwin89 marwin89 merged commit e53a33c into main Nov 20, 2023
1 check passed
@marwin89 marwin89 deleted the update-website branch November 20, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants