-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spec] Define Versions: 0.1.0 till 1.1.0 #31
Comments
To get things started. What about this? Please add or correct 🙏
Out of scope for this version: duet, medley, vocals, instrumental, etc.? |
I'd define version 0.1.0, but also treat every file without a As for bare minimum i'd only include the header tags:
Things like covers and backgrounds are all optional for the notetypes i'd say:
Because the others are also both optional Then from this version on. We'll have 2 more versions within the 0.x series: |
Here is a new spreadsheet table page for us to organize the versions. edit as you like: |
Updated format version spreadsheet: 📝 🔗 Versions Overview Spreadsheet Please mind: release date of format versions and implementation date are different things. You decide when the new versions are implemented in your software |
The spreadsheet is a nice idea but it would be nice if it contained all information and was a single point of truth. Now by looking just at it I feel like I'm missing half of the info that is probably spread over various issues here on github. Could you please add info why the tags were deemed deprecated and why others were renamed? Also, what are the new tags supposed to mean? e.g. #ONLINE ? |
But why? Can't we treat version 0.2.0 (using excel numeration) as default version? |
I would suggest:
|
Overall: a lot has been discussed in other issues. It might be hard to follow all of the activity, but i tried my best to summarize it here based on your statements/questions @Nianna
The spreadsheet will be long gone after things have finalized. The single point of truth will be this repository
This has to do with an open issue #24 as noted the namechange will only happen after 1.0.0 in which these tags can get deprecated. Also everything currently in 1.1.0 or higher is only theoretical so please join these active tickets. It's not set in stone yet
Also an open item as of yet #22
Purely to define the basics you need to get started. Yes i agree that many texts out there already contain a lot more, but if you'd just want to have a song to be singable in all of the apps these need to be defined. However we can automate things when certain tags are available to make it up to atleast 0.2.0 (as most songs probably would qualify). This will be a seperate process and is out of scope for this discussion.
I agree that the collected list is a reference list. For the 1.0.0 we already scrapped some tags like
Every version after 1.0.0 can contain anything new and shiny. Agreed. This is already reflected within the spreadsheet.
I disagree. Sure the software should catch up eventually. But we won't be able to control what everyone on the web is doing. So there's no need for us stopping to invent stuff and come up with things.
Since we're using semver this is already the case. Please read up on the linked comment of mine :) #13 (comment)
Tools like usdb-syncer or creator software should always try to aim for the last version. This will make sure that eventually all the songs get pushed towards the latest. Like also already mentioned we could create statistics about version usage and eventually try to bump everything to the latest. But this will be a huge operation. IMHO we or an automation tool shouldn't alter users local songs. That's the job of the song-providers (usdb.animux.de / ultrastar-es / others) and creator software. Karaoke programs will have to probably implement all the versions to be of best service. However if they want they can start from 1.0.0 and hopefully soonish we'll have everything ported to 1.0.0 |
Do we need |
I've updated the spreadsheet |
I'm not quite sure why |
I just meant to use it as a single point of truth while we work on the draft, with tags being linked to the related issues for reference. Just like @marwin89 did, thanks for that 👍
It's just not gonna happen. Also it will not update the songs that users have locally. Without any tool that we can tell the user to use, all formats will have to be supported like forever. But I never meant it to be a part of this project, so it's unrelated to this issue. I still do not see the point of having v0.1.0. Same with v0.3.0 - new version just to deprecate some tags? As you have said yourself- all tools will have to implement all versions. Why make the life harder for everyone and define 3 versions instead of 1? |
FYI: OVERVIEW Spreadsheet updated (semver strategy vs anual strategy) |
Pre-Condition for this issue: |
I think this is beneficial for communication with users. |
Summary / Final Results 🚩Thanks for discussing version structure. We voted for this in issue: Here are the final results. Result:
Version Table:Details:Our versions will start with this structure |
Suggestion
According to #13 strategy:
Use case
Start versioning. Having a version we can build up upon and categorize txt-file entries in hostings.
Extra info/examples/attachments
The text was updated successfully, but these errors were encountered: