Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete P3 hack #746

Closed
barbeque-squared opened this issue Sep 17, 2023 · 1 comment · Fixed by #824
Closed

Delete P3 hack #746

barbeque-squared opened this issue Sep 17, 2023 · 1 comment · Fixed by #824

Comments

@barbeque-squared
Copy link
Member

USDX currently implements a 'feature' that when it encounters a P3 tag, it's as if you had it in both P1 and P2. It will never actually get saved back though, it's able to parse it but that's it.

I've also never actually seen this used so I think it's time to remove it. Depending on how it handles the situation when the tag is still used and when it logs/crashes about it, I might postpone this until after #697.

See this discussion: UltraStar-Deluxe/format#17

@basisbit
Copy link
Member

basisbit commented Sep 17, 2023

I suggest only going forward with doing this once a consensus / new format is defined and implemented. Currently P3 tag is supported and it gets used by people/communities. This would be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants