Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New password proposal #304

Merged
merged 7 commits into from
Mar 17, 2022
Merged

New password proposal #304

merged 7 commits into from
Mar 17, 2022

Conversation

supremepot
Copy link
Contributor

I just work with Ipcam on my everyday, and during my work I see a lot this password

I just work with Ipecac on my everyday, and during my work I see a lot this password
Copy link
Owner

@Ullaakut Ullaakut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @supremepot ! Thanks for your PR :) Could you just order these alphabetically like the rest of the list? It makes it easier to spot duplicates if any ever slip in 🙏

Other than that, looks good to me!

@supremepot
Copy link
Contributor Author

Yes of course!

@supremepot
Copy link
Contributor Author

done! (I think)

dictionaries/credentials.json Outdated Show resolved Hide resolved
dictionaries/credentials.json Outdated Show resolved Hide resolved
dictionaries/credentials.json Outdated Show resolved Hide resolved
dictionaries/credentials.json Outdated Show resolved Hide resolved
supremepot and others added 3 commits March 17, 2022 14:27
Co-authored-by: Brendan Le Glaunec <[email protected]>
Co-authored-by: Brendan Le Glaunec <[email protected]>
Co-authored-by: Brendan Le Glaunec <[email protected]>
Copy link
Owner

@Ullaakut Ullaakut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :))

@Ullaakut Ullaakut merged commit 1cc3eaa into Ullaakut:master Mar 17, 2022
@supremepot
Copy link
Contributor Author

supremepot commented Mar 17, 2022

ok! now If I pull on docker, I can use the new password? thanks to you! :)

@Ullaakut
Copy link
Owner

Hi @supremepot

Not yet unfortunately, for that there would need to be a new release. If you want I can draft one this weekend :)

@supremepot
Copy link
Contributor Author

if possible... yes, thank u

@Ullaakut
Copy link
Owner

Hi @supremepot ! I did the release on GitHub and I am now uploading the updated docker images to docker hub. It will take a while though, since I am currently in a place where my connection is not great at all. It will probably take all day today to get the latest version available in Docker.

@supremepot
Copy link
Contributor Author

hi! thank u for your work! I pulled today and I think it's all ok!

@Ullaakut
Copy link
Owner

@supremepot Amazing :) Thanks to you for your contribution 🙏

@nelutzu777
Copy link

Please add Passwords:
Admin12345
Video12345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants