Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target .Net Core 3.0 desktop #64

Merged
merged 4 commits into from
Oct 11, 2019
Merged

Target .Net Core 3.0 desktop #64

merged 4 commits into from
Oct 11, 2019

Conversation

lbargaoanu
Copy link
Contributor

@lbargaoanu lbargaoanu commented Oct 11, 2019

Fixes #54.

@lbargaoanu lbargaoanu merged commit f6be52b into master Oct 11, 2019
@lbargaoanu lbargaoanu deleted the net_core_30 branch October 11, 2019 13:31
@ewinnington
Copy link
Contributor

Targeting netcoreapp3.0 with wpf does mean we lose out of x-platform ability, at least until we can use system.xaml as a separate nuget component.

@lbargaoanu
Copy link
Contributor Author

Yes, but I've no better idea. This is a clean way to bring System.Xaml into the mix. In theory System.Xaml shouldn't depend on anything Windows specific, but who knows :)

ThomasZitzler pushed a commit to ThomasZitzler/corewf that referenced this pull request Feb 13, 2020
This reverts commit f6be52b, reversing
changes made to 66da71b.
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Portable.Xaml with System.Xaml
2 participants