Disable the ETW event source by default #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmetzgar
approved these changes
Jul 15, 2022
AlvinStanescu
approved these changes
Jul 15, 2022
sergsuhanov
added a commit
to sergsuhanov/CoreWF
that referenced
this pull request
Jul 25, 2022
Disable the ETW event source by default (UiPath#212)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve execution performance, I have disabled the launch of ETW events, unless an environment variable is set.
I chose to only allow the value "true" (and its variations) to enable the events, in order to be able to switch between ETW on and off a bit faster, but if needed, we could also turn on the source if the environment variable exists, no matter what value it has.
ETW enabled, 1M iterations loop:
ETW disabled, 1M iterations loop:
