Skip to content

Prevent NullReferenceException in NameToken.GetHashCode() race condition #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BobLd merged 1 commit into from
Aug 19, 2026
Merged

Prevent NullReferenceException in NameToken.GetHashCode() race condition #1392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/UglyToad.PdfPig.Tokens/NameToken.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@

private NameToken(string text)
{
NameMap[text] = this;

Data = text;

NameMap[text] = this;
}

/// <summary>
Expand Down Expand Up @@ -76,7 +76,7 @@
/// <param name="name">The name token to convert.</param>
public static implicit operator string(NameToken name)
{
return name?.Data;

Check warning on line 79 in src/UglyToad.PdfPig.Tokens/NameToken.cs

View workflow job for this annotation

GitHub Actions / build 

Possible null reference return.
}

/// <summary>
Expand Down
Loading