make TokenScanner public through Structure to iterate indirect objects#1308
Merged
Conversation
BobLd
approved these changes
May 29, 2026
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR - I am using PdfPig in a custom PDF Renderer, and in order to render embedded XForm object, I need access to TokenScanner/PdfScanner publically.
This Supercedes - #1305
This is a screenshot of an early alpha build of SafePDF, intended to provide a free 99% memory safe PDF reader for the masses that is not vulnerable to the kind of buffer overrun CVEs as Acrobat. It's built with my custom UI toolkit Fluid, vector rendering using my SilkyNvg fork to which I added a Veldrid GPU backend (it's wicked fast).
Summary
It's a one-line visibility change. No new allocations, no behavioral changes, no breaking changes.
File:
src/UglyToad.PdfPig/Structure.csWhy
When rendering Form XObjects, the renderer must:
Page Dictionary → /Resources → /XObject → /<name>(entries are often indirect references)StreamTokenfor the Form XObject/Matrixarray from the stream dictionary (also potentially indirect)Each step requires
IPdfTokenScannerto dereferenceIndirectReferenceTokenvalues. PdfPig uses this scanner internally everywhere, but never exposed it for consumers who need to traverse dictionary trees themselves.Usage (consumer side)
Alternatives Considered
IGraphicsStateOperationlists in a way an external renderer can consume.