Use record struct in FileHeaderOffset #1161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EliotJones
reviewed
Sep 15, 2025
| obj is FileHeaderOffset other && value == other.Value; | ||
|
|
||
| public override int GetHashCode() => value.GetHashCode(); | ||
| public override int GetHashCode() => Value.GetHashCode(); |
Member
There was a problem hiding this comment.
Don't record structs provide these default implementations already?
There was a problem hiding this comment.
Yes, including the IEquatable implementation. See .NET Lab
Collaborator
Author
There was a problem hiding this comment.
They do, but with default implementation. It's seems to be more efficient for speed to provide it when possible. Ill provide the source of that shortly
Collaborator
Author
There was a problem hiding this comment.
not implementing these means it's going to use the EqualityComparer<int>.Default
In this specific case (single int in the struct), it's unsure if it's an actual improvement (might be an overkill).
See here for different benchmarks on record struct https://nietras.com/2021/06/14/csharp-10-record-struct/
EliotJones
approved these changes
Sep 15, 2025
This was referenced Nov 13, 2025
This was referenced Nov 23, 2025
This was referenced Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.