-
Notifications
You must be signed in to change notification settings - Fork 291
Draft release on master build #1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Love the idea, will review shortly |
|
@EliotJones in term of PR / merge, should we still aim to always merge to How does that behaves with the nightly releases currently in place? I'm happy with all your solutions (especially removing manual release), I'd just like to understand how this workflow would work with nightly releases. Thanks again! |
|
@BobLd yes nothing changes for the nightly releases. We still generate a nightly release each day there are new commits in master with the format This is the theory anyway, I ChatGPT-ed most of the actions code so no doubt there'll be some teething pain because actions and YAML hell is impossible to debug. |
|
Hehe perfect, thanks a lot |
|
@EliotJones the draft release was properly created on merge to We could try publishing the release and check all goes well publish the next version |
|
@BobLd I think we'll hold off on the next mainline release for now, my changes to xref parsing were risky so I want to give time for them to settle in via nightly releases and run more of the common crawl corpus. I'm sure chatgpt did the publish action perfectly 😂. Hopefully we can make the release before the end of October but I'm travelling again so it might be later. |
|
@EliotJones I'm going to release v0.1.12, let's see if that works EDIT: it worked as expected, except for push the version increment I'll push the change manually |

This PR changes the actions as follows:
This will remove the need for manual build and publish steps for major versions, instead we will manage these through github releases.