Skip to content

Conversation

@EliotJones
Copy link
Member

@EliotJones EliotJones commented Sep 7, 2025

This PR changes the actions as follows:

  • Remove the -alpha-001 postfix from all project version numbers
  • Pushes to master will draft a new release in GitHub
  • Publishing the release from GitHub will build, test and push the full version and then commit an increment for the version in the project files as well and assembly and file version

This will remove the need for manual build and publish steps for major versions, instead we will manage these through github releases.

@EliotJones EliotJones requested a review from BobLd September 7, 2025 13:54
@BobLd
Copy link
Collaborator

BobLd commented Sep 7, 2025

Love the idea, will review shortly

@BobLd
Copy link
Collaborator

BobLd commented Sep 8, 2025

@EliotJones in term of PR / merge, should we still aim to always merge to master then? It would create a (pre-)release and then we'd have the possibility to actual publish the release?

How does that behaves with the nightly releases currently in place?

I'm happy with all your solutions (especially removing manual release), I'd just like to understand how this workflow would work with nightly releases. Thanks again!

@EliotJones
Copy link
Member Author

@BobLd yes nothing changes for the nightly releases. We still generate a nightly release each day there are new commits in master with the format major.minor.patch-date-commit_sha and automatically push that to Nuget without any manual steps. However this change drafts a new release in GitHub on each commit to master. This draft should only be published when we're ready to make the full version release (0.1.9, 0.1.10, 0.1.11, etc). This is just removing the manual work for the full release step and doesn't change the existing nightly logic other than some changes in the scripts needed for the new major release actions.

This is the theory anyway, I ChatGPT-ed most of the actions code so no doubt there'll be some teething pain because actions and YAML hell is impossible to debug.

@BobLd
Copy link
Collaborator

BobLd commented Sep 8, 2025

Hehe perfect, thanks a lot

@BobLd BobLd merged commit 8408c98 into master Sep 8, 2025
2 checks passed
@EliotJones EliotJones deleted the draft-release-on-master-build branch September 9, 2025 07:56
@BobLd
Copy link
Collaborator

BobLd commented Sep 9, 2025

@EliotJones the draft release was properly created on merge to master.

We could try publishing the release and check all goes well publish the next version

@EliotJones
Copy link
Member Author

@BobLd I think we'll hold off on the next mainline release for now, my changes to xref parsing were risky so I want to give time for them to settle in via nightly releases and run more of the common crawl corpus. I'm sure chatgpt did the publish action perfectly 😂. Hopefully we can make the release before the end of October but I'm travelling again so it might be later.

@BobLd
Copy link
Collaborator

BobLd commented Nov 13, 2025

@EliotJones I'm going to release v0.1.12, let's see if that works

EDIT: it worked as expected, except for push the version increment
image

I'll push the change manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants