Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap 4 wrapper - broken show/hide events of date picker #228

Closed
Starzu opened this issue Oct 24, 2018 · 3 comments · Fixed by #825
Closed

Bootstrap 4 wrapper - broken show/hide events of date picker #228

Starzu opened this issue Oct 24, 2018 · 3 comments · Fixed by #825
Assignees
@ddworak
Milestone
0.9.0

Comments

@Starzu
Copy link
Contributor

Starzu commented Oct 24, 2018

Waiting for a fix in the wrapped library.
@ddworak
Copy link
Member

ddworak commented Sep 8, 2019

@bgrochal is this still an issue after #369?

@bgrochal
Copy link
Member

bgrochal commented Sep 9, 2019

Yes, it is. To clarify, this issue states that the io.udash.bootstrap.datepicker.UdashDatePicker.DatePickerEvent.Show event is not triggered when a date picker pops up because the show.datetimepicker event is not triggered by the underlying library. Hence, the show/hide on method call and emit events unit test (placed under io.udash.bootstrap.datepicker.UdashDatePickerTest) is ignored.

Related: tempusdominus/bootstrap-4/issues/227.

@ddworak ddworak closed this as completed Sep 9, 2019
@ddworak ddworak added this to the 0.8.0 milestone Sep 9, 2019
@ddworak ddworak reopened this Sep 9, 2019
@ddworak ddworak removed this from the 0.8.0 milestone Sep 9, 2019
@ddworak
Copy link
Member

ddworak commented Dec 12, 2019

There seems to be a fairly straightforward workaround in tempusdominus/bootstrap-4#227

@ddworak ddworak added this to the 0.9.0 milestone Dec 12, 2019
ddworak added a commit that referenced this issue Jul 9, 2021
@ddworak
Enable show/hide events testing for UdashDatePicker
d31090b 
Closes #228
ddworak added a commit that referenced this issue Jul 9, 2021
@ddworak
Fix show/hide events in UdashDatePicker
2fa8df6 
Closes #228
ddworak added a commit that referenced this issue Jul 9, 2021
@ddworak
Fix show/hide events in UdashDatePicker
2c0cf84 
Closes #228
@ddworak ddworak mentioned this issue Jul 9, 2021
Merged
@ddworak ddworak assigned ddworak and unassigned bgrochal Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddworak ddworak

Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

Fix show/hide events in UdashDatePicker UdashFramework/udash-core
3 participants
@Starzu @ddworak @bgrochal