Skip to content

Conversation

@ftnext
Copy link
Collaborator

@ftnext ftnext commented May 18, 2025

Vibe coded (refactoring based)

@ftnext ftnext requested a review from Copilot May 18, 2025 09:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new command ("sprc download vosk") to download and set up the Vosk model, refactoring the previous setup_vosk.py script into the CLI. Key changes include:

  • Adding a new CLI command in speech_recognition/cli.py for downloading and unzipping the Vosk model.
  • Removing the legacy setup_vosk.py script.
  • Updating setup.py, README.rst, and the GitHub Actions workflow to support the new command.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
speech_recognition/cli.py Introduces download_vosk_model function and CLI command for vosk.
setup_vosk.py Entirely removed to replace functionality with CLI command.
setup.py Adds a console script entry point for sprc CLI tool.
README.rst Updates instructions for Vosk model download and directory usage.
.github/workflows/unittests.yml Updates workflow to use the new sprc download vosk command.
Comments suppressed due to low confidence (1)

speech_recognition/cli.py:34

  • Consider verifying that the zip archive consistently extracts to a directory named after the model filename (without extension). If the archive structure deviates, the copy operation may fail; adding a check or more robust extraction logic could prevent potential issues.
extracted_dir = os.path.join(temp_dir, model_name)

@ftnext ftnext merged commit 46e7056 into Uberi:master May 18, 2025
8 checks passed
@ftnext ftnext deleted the codex/replace-requests-with-urllib-in-setup-vosk-py branch May 18, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant