Skip to content

Conversation

@ftnext
Copy link
Collaborator

@ftnext ftnext commented May 17, 2025

for near future refactoring

@ftnext ftnext requested a review from Copilot May 17, 2025 04:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new test for the vosk recognizer along with a script to download and set up the vosk model, preparing for future refactoring. Key changes include:

  • A new test file that verifies the output of the vosk recognizer.
  • A new setup script (setup_vosk.py) to download and extract the vosk model.
  • Dependency configuration updates and GitHub workflow modifications to include vosk.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
tests/recognizers/test_vosk.py Adds a test for the recognize_vosk() functionality
setup_vosk.py Introduces a script to download and extract the vosk model
setup.cfg Adds the vosk dependency configuration
.github/workflows/unittests.yml Updates dependency installations and adds a step to set up the vosk model

python -m pip install .[dev,whisper-local,faster-whisper,google-cloud,openai,groq]
python -m pip install .[dev,whisper-local,faster-whisper,google-cloud,openai,groq,vosk]
- name: Set up vosk model
run: pipx run setup_vosk.py
Copy link

Copilot AI May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] If setup_vosk.py is a local script rather than an installed package, consider using 'python setup_vosk.py' to ensure reliable execution within the workflow.

Suggested change
run: pipx run setup_vosk.py
run: python setup_vosk.py

Copilot uses AI. Check for mistakes.
@ftnext ftnext merged commit 3f3e0be into Uberi:master May 17, 2025
8 checks passed
@ftnext ftnext deleted the test-recognize-vosk branch May 17, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant