docs: add additional type inference for consumers #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftnext
requested changes
May 11, 2025
There was a problem hiding this comment.
Thanks for this PR adding type hints.
I noticed you've annotated the source parameter as Microphone type, but according to the docstring, it should accept any AudioSource object.
Why did you choose to use Microphone specifically rather than the more general AudioSource type?
Could you please update the PR to use AudioSource instead, which would better reflect the actual parameter requirements?
Thanks for your work on improving the library's type hints.
|
You're welcome. I originally went with I'll push up a change that makes the type |
hamirmahal
force-pushed
the
feat/additional-type-inference-for-consumers
branch
from
ff586ea to
c0902ec
Compare
|
You’re welcome! |
ftnext
changed the title
ftnext
added a commit
that referenced
this pull request
Sep 14, 2025
…e-840 docs: add additional type hints (follow up #840)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #839