Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forecasting bug fix #95

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Forecasting bug fix #95

merged 2 commits into from
Feb 25, 2024

Conversation

pritamd47
Copy link
Member

This updated PR addresses two bugs.

  • Fixes forecasted evaporation not being generated due to lack of surface area time-series. Now surface area is filled in the forecasting window by forward filling, which is used for estimating the evaporation.
  • Fixes a bug when RAT-Forecasting would fail if Tmin > Tmax forecasted by GFS (few cases, but can lead to run failing). In such scenarios, Tmin will be set equal to Tmax such that the forecasting module doesn't throw an error.

Copy link
Member

@SanchitMinocha SanchitMinocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing the bugs.

@SanchitMinocha SanchitMinocha merged commit 8ac2a86 into main Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants