Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun search queries when cache files are missing #90

Merged
merged 6 commits into from
Aug 17, 2023
Merged

Conversation

bbonf
Copy link

@bbonf bbonf commented Aug 16, 2023

Closes #42

@bbonf bbonf requested a review from tijmenbaarda August 16, 2023 12:48
@@ -83,6 +95,11 @@ def get_results(self) -> ResultSet:
self.save(update_fields=['last_accessed'])
return parse_search_result(results, self.component.slug)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An try/except ValueError handler should be added here in case the cache is invalid

@bbonf bbonf merged commit ae0aa15 into master Aug 17, 2023
@bbonf bbonf deleted the fix/missing-cache branch August 17, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants