RHS compare indicators and resizing when no semesters selected #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AbhiramTadepalli
approved these changes
Nov 27, 2024
|
Oh yeah seems reasonable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #304
What Changed
Re-adds check for -1 GPA (for some reason it was showing -1 as the GPA again on some professors). Adds empty space with same dimensions in the compare table when there is no GPA is -1, which minimizes jumping.
Other Notes
The bar graph still moves around a bit because the labels disappear and the graph height expands. If we wanted we could keep the labels visible to avoid this, but it seems like that could be confusing and it would get rid of the empty state text.