Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial #319

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

Tutorial #319

wants to merge 10 commits into from

Conversation

TyHil
Copy link
Member

@TyHil TyHil commented Nov 16, 2024

Overview

Ended up going with a step by step tutorial since I couldn't figure out how to have all the popups on screen at once, and that wouldn't work on mobile anyway.

What Changed

Added a tutorial component and various tags for elements it highlights sprinkled around the code.

Other Notes

I have not added a feedback popup. This may require more discussion but making it so easy to submit feedback could open us up to spam. Currently, technical knowledge is required to spam us but this could make it too easy. I could see it working if it went to a different place and had just the question with no star rating. But overall I don't see the point in asking the people who have actually hit the question mark icon what they think about the site when they are the ones who have barely used it.

There is a known issue on mobile where each step in the tutorial rescrolls from the top of the page to the designated element, not sure why rn.

@TyHil TyHil linked an issue Nov 16, 2024 that may be closed by this pull request
Copy link

vercel bot commented Nov 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
utd-trends ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2024 0:45am

@AbhiramTadepalli
Copy link
Contributor

😍

I'll take a closer look in a bit


I'd like to have a place to give feedback and display changelog. Is that something we can incorporate with the question mark or a different place/icon?

Like can the question mark open a component at the top-right with changelog, button to start tutorial, and place to leave review/feedback/bug?

@TyHil
Copy link
Member Author

TyHil commented Nov 16, 2024

I'd suggest maybe a third icon for feedback and changelog: https://mui.com/material-ui/material-icons/?query=feedback&selected=Feedback

The feedback could go to a separate place from the star rating popup

Would the changelog be integrated into the website or a link to the GitHub releases page?

@AbhiramTadepalli
Copy link
Contributor

AbhiramTadepalli commented Nov 16, 2024

#313

That or an info icon

@AbhiramTadepalli
Copy link
Contributor

Can you have a card about the compare page?

@TyHil
Copy link
Member Author

TyHil commented Nov 22, 2024

I couldn't get any highlighting to work inside the RHS because of the position fixed stuff. I was hoping highlighting the checkbox would be good enough but I could elaborate in that step on compare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add a Tutorial
2 participants