Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated RMP Tags #297

Merged
merged 20 commits into from
Nov 16, 2024
Merged

Updated RMP Tags #297

merged 20 commits into from
Nov 16, 2024

Conversation

GovindRangappa
Copy link
Contributor

Overview

Resolves RMP Tags being loaded in

Loaded in the RMP Tag data and output the top 10 under the graph

What Changed

singleProfInfo.tsx was the only updated file. Added a section for the tag data to be loaded in

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
utd-trends ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2024 2:33am

@AbhiramTadepalli
Copy link
Contributor

@GovindRangappa @RVC13850 @TyHil is there any reason to ever omit tags from the top 10 because of their frequency?

https://utd-trends-1qa6ktyhi-utdnebula.vercel.app/dashboard?searchTerms=Gopal+Gupta
Like Tough grader, (1) Skip class? You won't pass. (1), Amazing lectures (1), Clear grading criteria (1)

I'm leaning towards leaving it as is because you can see the frequency

@AbhiramTadepalli
Copy link
Contributor

AbhiramTadepalli commented Nov 10, 2024

Also (all 3 of you) for the above commit:

  • I removed outline
  • I made the text bigger. Should it go back to being smaller? Should I add padding? semi-bold the text? Is it fine as-is?
  • In dark mode, should the bg color be darker?

What are your thoughts on these changes?

@AbhiramTadepalli
Copy link
Contributor

AbhiramTadepalli commented Nov 10, 2024

image
∧ Pipes separating tags vs Commas ∨

image


Should the overall tooltip have a hover at all?


@TyHil is there a better way to find topTags in searchResultsTable.tsx?

@TyHil
Copy link
Member

TyHil commented Nov 11, 2024

@TyHil is there a better way to find topTags in searchResultsTable.tsx?

Looks good to me. We could do the sorting immediately once the data is fetched tho so it's not done in multiple places

@GovindRangappa what do you think about the other questions?

@RVC13850
Copy link
Contributor

on light mode make it cornflower 100. on dark mode maybe keep the outline and match color with star

@AbhiramTadepalli
Copy link
Contributor

@GovindRangappa @TyHil do you think (in dark mode) the color of the tag needs to be the same as the stars?

@TyHil
Copy link
Member

TyHil commented Nov 11, 2024

Depends on how much we want to emphasize the tags. I'm not sure if they really need to pop like that

@GovindRangappa
Copy link
Contributor Author

I like how the purple make the tags in the dropdown card look in dark mode. Only thing that I think has the potential to look better is centering the tags above the course name when hovered over rather than staggering them to the right. I do like the commas better than the | thing as it's a familiar punctuation that people are used to seeing and understanding.

so it doesn't show up on overall
@AbhiramTadepalli
Copy link
Contributor

WHAT! ANIMATIONS!!!!!!!

@AbhiramTadepalli
Copy link
Contributor

guys this might increase the engagement time on our website I WILL BE CLICKING THE MORE TAGS ANIMATION

@AbhiramTadepalli
Copy link
Contributor

Andrew Nemec has no ratings - https://utd-trends-l3ddjbdvm-utdnebula.vercel.app/dashboard?searchTerms=Andrew+Nemec -> Should indicate no tags found?
B. Chitturi's RMP is not found by trends - https://utd-trends-l3ddjbdvm-utdnebula.vercel.app/dashboard?searchTerms=Bhadrachalam+Chitturi -> No tag on hover, maybe it should indicate that there are no tags found?

@TyHil
Copy link
Member

TyHil commented Nov 15, 2024

Andrew Nemec has no ratings - https://utd-trends-l3ddjbdvm-utdnebula.vercel.app/dashboard?searchTerms=Andrew+Nemec -> Should indicate no tags found? B. Chitturi's RMP is not found by trends - https://utd-trends-l3ddjbdvm-utdnebula.vercel.app/dashboard?searchTerms=Bhadrachalam+Chitturi -> No tag on hover, maybe it should indicate that there are no tags found?

oh yeah good point, lemme fix that

@AbhiramTadepalli
Copy link
Contributor

The B. Chitturi case messes with the overall no-tag

@AbhiramTadepalli
Copy link
Contributor

@TyHil idt that fixes Chitturi. I get nothing on hover for him. I think it's because his rmp data is null (same for overall)

@TyHil
Copy link
Member

TyHil commented Nov 16, 2024

@AbhiramTadepalli ok that should do it. It will either say "No Tags Available" or list the tags on every results unless it's just a course, like "CS 1200 (Overall)"

Copy link
Contributor

@AbhiramTadepalli AbhiramTadepalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, Looks good!

@AbhiramTadepalli AbhiramTadepalli merged commit 86e586b into develop Nov 16, 2024
3 checks passed
@AbhiramTadepalli AbhiramTadepalli deleted the IssueRMPTagsLoadIn branch November 16, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants