-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated RMP Tags #297
Updated RMP Tags #297
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@GovindRangappa @RVC13850 @TyHil is there any reason to ever omit tags from the top 10 because of their frequency? https://utd-trends-1qa6ktyhi-utdnebula.vercel.app/dashboard?searchTerms=Gopal+Gupta I'm leaning towards leaving it as is because you can see the frequency |
Also (all 3 of you) for the above commit:
What are your thoughts on these changes? |
Should the overall tooltip have a hover at all? @TyHil is there a better way to find topTags in |
Looks good to me. We could do the sorting immediately once the data is fetched tho so it's not done in multiple places @GovindRangappa what do you think about the other questions? |
on light mode make it cornflower 100. on dark mode maybe keep the outline and match color with star |
@GovindRangappa @TyHil do you think (in dark mode) the color of the tag needs to be the same as the stars? |
Depends on how much we want to emphasize the tags. I'm not sure if they really need to pop like that |
I like how the purple make the tags in the dropdown card look in dark mode. Only thing that I think has the potential to look better is centering the tags above the course name when hovered over rather than staggering them to the right. I do like the commas better than the | thing as it's a familiar punctuation that people are used to seeing and understanding. |
so it doesn't show up on overall
WHAT! ANIMATIONS!!!!!!! |
guys this might increase the engagement time on our website I WILL BE CLICKING THE MORE TAGS ANIMATION |
Andrew Nemec has no ratings - https://utd-trends-l3ddjbdvm-utdnebula.vercel.app/dashboard?searchTerms=Andrew+Nemec -> Should indicate no tags found? |
oh yeah good point, lemme fix that |
The B. Chitturi case messes with the overall no-tag |
@TyHil idt that fixes Chitturi. I get nothing on hover for him. I think it's because his rmp data is null (same for overall) |
@AbhiramTadepalli ok that should do it. It will either say "No Tags Available" or list the tags on every results unless it's just a course, like "CS 1200 (Overall)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, Looks good!
Overview
Resolves RMP Tags being loaded in
Loaded in the RMP Tag data and output the top 10 under the graph
What Changed
singleProfInfo.tsx was the only updated file. Added a section for the tag data to be loaded in