Add linting and formatting check #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake3231
reviewed
Jan 22, 2024
| @@ -1,4 +1,4 @@ | |||
| name: "Submit to Web Store" | |||
| name: 'Submit to Web Store' | |||
There was a problem hiding this comment.
Do we need to make this change?
There was a problem hiding this comment.
No, I could exclude this file from Prettier
There was a problem hiding this comment.
I trust your discretion on that.
|
Also, have we verified that this works when installing the plugin? |
|
Yup, pretty much all linter changes. It works for me, yes. |
|
Given that all works I think we're good to merge, but another review would be great. |
|
Just swapped this PRs base branch over to |
Jake3231
added a commit
that referenced
this pull request
Feb 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #43
Add prettier and ESLint.
Add format and lint scripts in
package.json.Run scripts on pre-commit (local) and commit (github).
Run prettier and fix ESLint warnings.