Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKEDGE-14 #comment convert to async/await instead of .then() logics, organizing awaits #30

Merged
merged 8 commits into from
Jun 9, 2023
Merged

SKEDGE-14 #comment convert to async/await instead of .then() logics, organizing awaits #30

merged 8 commits into from
Jun 9, 2023

Commits on Mar 28, 2023

  1. SKEDGE-14 #comment convert to async/await instead of .then() logics, … 

    …organizing awaits
    @demonlexe
    demonlexe committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    76e542f View commit details
    Browse the repository at this point in the history

  2. SKEDGE-14 logic to patch CS4348 for Scott Dollinger. If there are mul… 

    …tiple listings for a professor on RMP, use the one with the most ratings.
    @demonlexe
    demonlexe committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    2fd7740 View commit details
    Browse the repository at this point in the history

  3. SKEDGE-14 #comment add function to group properties, use this functio… 

    …n for the RMP fetches to avoid 504 error.

#comment address requests from Adam Szumski
#comment add new interfaces for the Professor Rating object
    @demonlexe
    demonlexe committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    b5fcd34 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. move functions, add comments

    @demonlexe
    demonlexe committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    2dd8451 View commit details
    Browse the repository at this point in the history

  2. add reportError function, to be modified later; use fetchRetry for in… 

    …itial fetches of professors from RMP
    @demonlexe
    demonlexe committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    d8b9bc4 View commit details
    Browse the repository at this point in the history

  3. SKEDGE-14 #comment modularize retry logic inside validateResponses fu… 

    …nction, instead of grouping fetches.

(This way seems shorter and safer)
    @demonlexe
    demonlexe committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    dfe3809 View commit details
    Browse the repository at this point in the history

  4. SKEDGE-14 #comment remove groupProps

    @demonlexe
    demonlexe committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    16295b5 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. SKEDGE-14 #comment use fetchOptions if needed to re-fetch rmp graphql… 

    … data
    @demonlexe
    demonlexe committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    517598e View commit details
    Browse the repository at this point in the history