NP-24 Restrict sidebar auto-scrolling #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel Preview URL 🚀 : https://planner-bpbqs6a9l-utdnebula.vercel.app |
|
Vercel Preview URL 🚀 : https://planner-22mjez3t6-utdnebula.vercel.app |
|
@cubetastic33 I know I was ambiguous about this before, but let's do just reviewer merge for simplicity sake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes NP-24. Previously, when a course was dragged to the bottom of the planner screen the sidebar would scroll as well. This is because the way DndContext is defined. This fix restricts the sidebar from scrolling when a course is being dragged, so only the planner component can auto-scroll.
What Changed
Added a courseDragged prop to sidebar that determines whether or not is should be able to scroll. If a course is being dragged, then y-overflow is hidden on the sidebar object.
Other Notes
This creates a small visual issue where the sidebar must disappear while the scrolling is restricted. I couldn't find a solution to this using tailwind, but it isn't that noticeable of an issue.