feature: filter timeline steps by result quality #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infacc
changed the title
buehlefs
reviewed
Oct 26, 2023
src/app/components/experiment-timeline/experiment-timeline.component.html
Outdated
Show resolved
Hide resolved
| @@ -50,6 +50,16 @@ export class ExperimentTimelineComponent implements OnInit, OnDestroy { | |||
| { value: 1, viewValue: "Only steps with uncleared substeps" }, | |||
| { value: -1, viewValue: "Only steps with cleared substeps" } | |||
| ]; | |||
| resultQuality: ExperimentResultQuality | "" = ""; | |||
| resultQualityValues: SelectValue[] = [ | |||
There was a problem hiding this comment.
It would be great (but not required) if the SelectValue interface is generic in the type for value so that the value entries here could be properly type checked.
There was a problem hiding this comment.
The use of a SelectValue interface is now avoided completely for the resultQualityValues.
buehlefs
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires UST-QuAntiL/qhana-backend#54
Fixes #64