Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regain/identify expertise in svginject@vizlab #373

Open
aappling-usgs opened this issue Apr 27, 2018 · 5 comments
Open

regain/identify expertise in svginject@vizlab #373

aappling-usgs opened this issue Apr 27, 2018 · 5 comments

Comments

@aappling-usgs
Copy link
Member

Jordan Walker resolved use the svginject javascript library (#187), but we have this warning in water-use-15:

In publish.svg(viz) :
  inline option is deprecated, all SVGs now use svg-inject

suggesting that we're not making use of Jordan's work. We need to identify a current team member who knows about this and can watch for it and consult the team on the use of svginject. if that expertise already exists then we just need to know who has it, otherwise, someone should go figure this out to become our expert.

@jordansread
Copy link

Is this potentially happening w/ the svg in the header? Or other small svgs that would be doing the same.

In the header:

<img class="vizlab-landscape vizlab-portrait" src="images/usgsLogo.svg" title="U.S. Geological Survey" alt="U.S. Geological Survey">

@aappling-usgs
Copy link
Member Author

What do you mean by "this"?

@jordansread
Copy link

the warning = this.

@aappling-usgs
Copy link
Member Author

ah. could be, i think we need someone to investigate. to me this is not a priority for water-use-15, though, so timing of addressing this issue should be vizlab timing, not water use viz timing.

@ldecicco-USGS
Copy link
Contributor

I just added:

svg-injector-js: lib-svg-injector-js

to the viz.yaml in water-use-15 (and then put svg-injector-js) in the resources and the warning went away. That's all that I'm aware that we did in the hurricane viz's.

I'm not sure if we need to do some benchmarking to see if that helps or not. I have zero idea how svg-inject plays with D3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants