Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the svginject javascript library #187

Closed
aappling-usgs opened this issue Sep 8, 2017 · 4 comments
Closed

use the svginject javascript library #187

aappling-usgs opened this issue Sep 8, 2017 · 4 comments
Assignees

Comments

@aappling-usgs
Copy link
Member

problems with getting twitter to pick up a tweet/card can be partly addressed by using the svginject javascript library, which would reduce page size. the library tells the client that svg is there, without actually loading it until needed

@jiwalker-usgs
Copy link
Contributor

svg-inject allows a png fallback, we may want to consider supporting that.

@aappling-usgs
Copy link
Member Author

all implemented on @jiwalker-usgs 's computer, just needs testing

@aappling-usgs
Copy link
Member Author

need laura's PR merged for the example to build, need alison's PR merged to check for conflicts

@jiwalker-usgs
Copy link
Contributor

#218 changes how SVGs work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants