Fixes #266: Add more acceptable phrases #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
libraun
commented
Sep 24, 2024
libraun
commented
- Added new routine, "ScanSub", that allows the player to simply "scan fob" while inside the tutorial;
- Extended verb "show" to be synonymous with "insert" (for inserting fob into scanner);
- Added one test to ensure that additional dialogue is printed if the player attempts to scan their fob twice (without picking it up first);
- Added multiple tests for variations of "show" and "insert" fob/card/id into scanner, and a test for "scan fob"
- Changed one test that had an ambiguous reference to "card"
…ecurity card FOB in the Tutorial elevator (instead of 'insert fob into scanner'); added failing test, which checks that punyinform indicates that the player first picks up the fob before scanning it a second time.
…e stating that the player first grabs the fob before inserting it a second time, IF they do not 'take fob' after inserting initially.
…an fob twice consecutively' to test synonyms 'id' and 'card' for fob.
…sts for new verb 'show'. Also Extended 'show' verb to be synonymous with 'insert'.
pahp
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.