Skip to content

fix: 현재 위치 이동 애니메이션으로 전환, 곡 정보 페이지 뒤로가기 클릭 시 바텀시트 표시 - #359

Merged
L0521 merged 2 commits into
developfrom
fix/355-current-location-flyto
Aug 12, 2026
Merged

L0521 merged 2 commits into
developfrom
fix/355-current-location-flyto

Conversation

@L0521

@L0521 L0521 commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

변경 내용

  • 현재 위치 재중심 이동을 flyTo 애니메이션으로 전환
  • 상세 정보 페이지 뒤로가기 클릭 시 바텀시트 표시

관련 이슈

Closes #355

변경 사항

  • 새로운 기능 추가
  • 버그 수정
  • UI/UX 개선
  • 리팩토링
  • 문서 업데이트

테스트

  • 브라우저에서 정상 동작 확인
  • 기존 기능에 영향 없음 확인

스크린샷 (UI 변경시)

체크리스트

  • 코드가 정상적으로 동작합니다
  • 새로운 에러나 경고가 없습니다
  • 필요시 문서를 업데이트했습니다
  • 코드 포맷팅을 실행했습니다 (pnpm format)
  • ESLint 검사를 통과했습니다 (pnpm lint:fix)

코드 품질 확인
PR 제출 전에 다음 명령어를 실행하여 코드 품질을 확인해주세요:

pnpm lint:fix
pnpm format

Summary by CodeRabbit

  • 개선 사항
    • 현재 위치로 재중심할 때 지도가 더 자연스럽게 이동하도록 개선했습니다.
    • 재중심 시 위치와 적절한 확대 수준이 한 번에 적용됩니다.

@L0521 L0521 self-assigned this Aug 12, 2026
@L0521 L0521 added the enhancement New feature or request label Aug 12, 2026
@coderabbitai

coderabbitai Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@L0521, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5980c7b9-e5c6-4eb1-bfeb-8d1347f1dfb7

📥 Commits

Reviewing files that changed from the base of the PR and between 9a99bf6 and 7b3f7e8.

📒 Files selected for processing (1)
  • src/pages/MapPage.tsx

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f353b080-c102-4299-85d3-9bb7d405ebcc

📥 Commits

Reviewing files that changed from the base of the PR and between 040c26e and 9a99bf6.

📒 Files selected for processing (2)
  • src/features/map/components/MapViewer.tsx
  • src/features/map/hooks/useCurrentLocationMarker.ts

📝 Walkthrough

Walkthrough

현재 위치 재중심 기능이 직접 setZoom과 panTo를 호출하지 않고 flyTo를 사용하도록 변경되었습니다. MapViewer는 flyTo를 useCurrentLocationMarker에 전달합니다.

Changes

현재 위치 재중심 이동

Layer / File(s) Summary
flyTo 기반 재중심 이동
src/features/map/hooks/useCurrentLocationMarker.ts, src/features/map/components/MapViewer.tsx
useCurrentLocationMarker에 필수 flyTo 파라미터를 추가했습니다. 재중심 시 flyTo(position, RECENTER_ZOOM)을 호출하도록 변경했습니다. MapViewer는 flyTo를 훅에 전달합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: bug

Suggested reviewers: onebone

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning 현재 위치 재중심 애니메이션은 구현했지만, 곡 상세 페이지 뒤로가기 동작에 대한 변경 사항은 확인되지 않습니다. 곡 상세 페이지의 뒤로가기 동작이 진입 전 화면과 바텀시트를 표시하도록 구현되었는지 확인하고 관련 변경을 추가하십시오.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 현재 위치 이동 애니메이션 변경을 설명하지만, 변경 사항에 없는 곡 정보 페이지 바텀시트 동작도 포함합니다.
Out of Scope Changes check ✅ Passed 확인된 코드는 현재 위치 재중심 동작에만 관련되며, 연결된 이슈와 무관한 코드 변경은 보이지 않습니다.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/355-current-location-flyto

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

https://pr-359.plimap.kr

@L0521
L0521 merged commit 9abe766 into develop Aug 12, 2026
3 of 4 checks passed
@L0521
L0521 deployed to preview-maintenance August 12, 2026 15:53 — with GitHub Actions Active
@L0521
L0521 deleted the fix/355-current-location-flyto branch August 13, 2026 12:40

This branch was successfully deployed

1 active deployment
preview-maintenance — 7b3f7e80 Deployed Aug 12, 2026 by L0521 via cleanup #605
preview — 7b3f7e80 Deployed Aug 12, 2026 by L0521 via deploy #603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QA 이슈 수정

1 participant