fix : 피드 진입 시 지도 핀 말풍선 표시 및 재생 파형 그라데이션 - #279
Merged
Merged
Conversation
📝 WalkthroughWalkthrough피드에서 지도에 진입하면 해당 핀의 말풍선을 표시하고 Changes피드 지도 진입
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant 피드
participant useOpenPinPlaceOnMap
participant MapPage
participant MapViewer
피드->>useOpenPinPlaceOnMap: 장소와 placeTrackId 전달
useOpenPinPlaceOnMap->>MapPage: mapFocusPin 반환
MapPage->>MapViewer: flyTo 좌표와 PIN_FOCUS_ZOOM 전달
MapViewer-->>MapPage: 지도 이동 완료
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/features/map/components/MapPinMessageBox.css`:
- Around line 85-86: MapPinMessageBox.css의 해당 스타일 선언 블록에서 -webkit-mask 선언 바로 앞에
빈 줄을 추가하여 declaration-empty-line-before Stylelint 규칙을 만족시키세요.
In `@src/features/pin/hooks/useOpenPinPlaceOnMap.ts`:
- Around line 134-137: Update the resolvedPlaceTrackId validation in the
placeTrackId resolution logic to accept only positive integer IDs, using
Number.isInteger(...) and a greater-than-zero check. Preserve undefined for
zero, negative, fractional, and invalid numeric-string values before they reach
findFocusedPlaceTrackId() and the detail CTA.
In `@src/pages/MapPage.tsx`:
- Around line 215-221: Update the feed-entry UI branches to consistently use
isFeedMapEntry, including isRegisterButtonVisible and onFullPageBack. Ensure
mapFocusPin-only entries are treated like all other feed entries: hide the
registration button and avoid navigating back to the place-search screen.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: cbb299e3-4e4d-4763-bf10-8c8f7f3ce8b4
📒 Files selected for processing (8)
src/features/map/components/MapPinMessageBox.csssrc/features/map/components/MapPinMessageBox.tsxsrc/features/map/components/MapViewer.tsxsrc/features/map/hooks/useMapPinOverlays.tssrc/features/pin/components/PinListSheet.tsxsrc/features/pin/hooks/useOpenPinPlaceOnMap.tssrc/features/pin/types.tssrc/pages/MapPage.tsx
Member
Author
|
@coderabbitai review |
Member
Author
|
@coderabbitai full review |
JeongGyul
approved these changes
Aug 9, 2026
Member
Author
|
@coderabbitai resolve |
kim3360
temporarily deployed
to
preview-maintenance
August 9, 2026 19:27 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
✅ Action performedComments resolved and changes approved. |
kim3360
temporarily deployed
to
preview-maintenance
August 9, 2026 19:28 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
12 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 내용
관련 이슈
Closes #278
변경 사항
테스트
스크린샷 (UI 변경시)
체크리스트
pnpm format)pnpm lint:fix)코드 품질 확인
PR 제출 전에 다음 명령어를 실행하여 코드 품질을 확인해주세요:
Summary by CodeRabbit
새로운 기능
버그 수정