fix : 장소 접근 토큰·곡 상세 로딩 및 MY 장소 상세 열람 - #272
Conversation
|
Warning Review limit reached
Next review available in: 40 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough장소 접근 토큰을 지도 라우팅 state로 전달하고, 곡 상세 및 핀 목록 조회에 사용합니다. 피드 진입 장소와 본인 등록 장소의 곡 상세 접근 조건을 반영합니다. 현재 위치가 없으면 선택 장소 또는 핀 좌표를 사용합니다. Changes장소 곡 상세 접근 흐름
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/features/pin/hooks/useOpenPinPlaceOnMap.ts`:
- Around line 116-123: `resolvePlace`에서 확정한 `place.isMine`을 최종 소유권 기준으로 사용하도록 토큰
발급 조건을 수정하세요. 호출 시점의 `isMine`만으로 `postFeedPlaceAccessRequest`를 실행하지 말고,
`placeDetail.pinnedByMe`로 계산된 장소 소유권을 확인한 뒤 타인 장소일 때만 토큰을 저장하고 전달하세요.
In `@src/pages/MapPage.tsx`:
- Around line 484-517: Update the PinListSheet detailLocation calculation to use
the same currentLocation and selectionLocation fallbacks, then fall back to
selectedMapPlace.coordinates and the selectedMapPin coordinates as applicable.
Ensure this resolved location is passed to PinListSheet so usePlaceDetail and
usePlaceTrack remain enabled and pin clicks work when higher-priority locations
are unavailable.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: b9f0df3e-d39e-43c7-9dec-fafcb52f5032
📒 Files selected for processing (5)
src/features/pin/components/PinListSheet.tsxsrc/features/pin/hooks/useOpenPinPlaceOnMap.tssrc/features/pin/types.tssrc/pages/MapPage.tsxsrc/pages/PinDetailPage.tsx
GitHub Actions
Inactive
This branch was successfully deployed
1 participant
변경 내용
관련 이슈
Closes #270
변경 사항
테스트
스크린샷 (UI 변경시)
체크리스트
pnpm format)pnpm lint:fix)코드 품질 확인
PR 제출 전에 다음 명령어를 실행하여 코드 품질을 확인해주세요:
Summary by CodeRabbit