feat : 다른 사용자 프로필 조회 API 연동 - #204
Conversation
|
Warning Review limit reached
Next review available in: 11 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthrough타인 회원 프로필 라우트와 조회 기능을 추가했습니다. 프로필의 팔로우와 공유 동작을 연결했습니다. 핀 피드의 닉네임을 클릭하면 작성자 프로필로 이동합니다. 기존 목 데이터 파일을 삭제했습니다. Changes타인 회원 프로필 기능
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Browser
participant UserProfilePage
participant useOtherMemberProfile
participant getOtherMemberProfile
participant useInfiniteOtherMemberFeed
participant getOtherMemberFeed
Browser->>UserProfilePage: users/:memberId 경로 접근
UserProfilePage->>useOtherMemberProfile: memberId 전달
useOtherMemberProfile->>getOtherMemberProfile: 숫자 memberId로 프로필 요청
UserProfilePage->>useInfiniteOtherMemberFeed: memberId와 pageSize 전달
useInfiniteOtherMemberFeed->>getOtherMemberFeed: 커서 기반 피드 요청
getOtherMemberFeed-->>useInfiniteOtherMemberFeed: 피드 페이지 반환
UserProfilePage-->>Browser: 프로필과 핀 피드 렌더링
Possibly related issues
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1⚔️ Resolve merge conflicts 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/hooks/useOtherMemberProfile.ts`:
- Around line 10-11: Update the query configuration in useOtherMemberProfile so
only a valid integer memberId enables the query and reaches
getOtherMemberProfile. Derive and validate the numeric ID once, reject
non-numeric, fractional, or otherwise invalid values such as "abc", and use that
validated value for both enabled and queryFn.
In `@src/pages/UserProfilePage.tsx`:
- Line 91: The UserProfilePage feed rendering only shows the currently cached
pages and never triggers loading of additional pages, so pins after the initial
batch are missing even when more data exists. Update UserProfilePage to use the
infinite-feed controls from useInfiniteOtherMemberFeed, specifically
fetchNextPage, hasNextPage, and isFetchingNextPage, and wire them to a
bottom-of-list trigger such as a button or intersection observer. Keep
ProfilePinGrid as the display target, but append the next-page request logic so
the list can continue loading beyond the first page when hasNextPage is true.
- Around line 16-22: Update UserProfilePage’s useOtherMemberProfile call to
receive the same validated positive numeric ID used by
useInfiniteOtherMemberFeed, passing undefined for invalid memberId values such
as non-numeric or non-positive paths.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 79cefd7a-9ca9-4bd8-b59a-67d7e2b4c191
📒 Files selected for processing (14)
src/api/pin.tssrc/features/pin/components/SongFeedCard.tsxsrc/features/pin/data/mockPinSearchPlaces.tssrc/features/pin/queries/useOtherMemberFeed.tssrc/features/pin/types.tssrc/features/profile/components/ProfileActions.tsxsrc/features/profile/components/ProfileInfo.tsxsrc/features/profile/components/ProfilePinGrid.tsxsrc/hooks/useFollowMember.tssrc/hooks/useOtherMemberProfile.tssrc/pages/MyProfilePage.tsxsrc/pages/PinDetailPage.tsxsrc/pages/UserProfilePage.tsxsrc/routes/index.tsx
💤 Files with no reviewable changes (1)
- src/features/pin/data/mockPinSearchPlaces.ts
변경 내용
타인 피드 목록 조회 API를 연동했습니다.
getOtherMemberFeedAPI +useInfiniteOtherMemberFeed훅 추가/app/my, 타인 →/app/users/:memberId)UserProfilePage에서 타인 피드를ProfilePinGrid로 표시관련 이슈
Closes #194
변경 사항
테스트
스크린샷 (UI 변경시)
2026-08-05.7.48.25.mov
체크리스트
pnpm format)pnpm lint:fix)코드 품질 확인
PR 제출 전에 다음 명령어를 실행하여 코드 품질을 확인해주세요:
Summary by CodeRabbit
새로운 기능
개선 사항