핀 장소 상세 조회 API 연동 - #166
Conversation
|
Warning Review limit reached
Next review available in: 2 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough이 PR은 PinListSheet가 내부에서 현재 위치를 조회하는 방식 대신 외부에서 전달된 detailLocation을 사용하도록 변경한다. 북마크 상태를 loading, error, ready로 구분하여 UI와 접근성 속성에 반영한다. PinSearchPlace 타입에 selectionLocation을 추가하고, PinPlaceSearch와 MapPage에서 위치 정보를 전달하도록 수정한다. ChangesPinListSheet 상세 위치 전달 및 북마크 상태
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant PinPlaceSearch
participant MapPage
participant PinListSheet
User->>PinPlaceSearch: 장소 선택
PinPlaceSearch->>PinPlaceSearch: 현재 위치를 selectionLocation으로 추가
PinPlaceSearch->>MapPage: 보강된 장소 객체 전달
MapPage->>PinListSheet: detailLocation 전달 (selectionLocation 우선, 없으면 현재 위치)
PinListSheet->>PinListSheet: detailLocation 좌표로 상세 조회
PinListSheet->>PinListSheet: 장소 정보 및 북마크 상태 보정 (loading/error/ready)
PinListSheet-->>User: 보정된 장소 정보 및 북마크 상태 렌더링
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cce669d to
a87c0fd
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai full review |
✅ Action performedFull review finished. Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 4 minutes. |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
a87c0fd to
f0c8115
Compare
f0c8115 to
3895b70
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/pages/MapPage.tsx`:
- Around line 276-281: Update MapPage’s current-location state handling so the
error delivered by MapViewer’s onCurrentLocationError is preserved instead of
being passed only to setCurrentLocation. Propagate that error to PinListSheet
alongside detailLocation, or expose it there as a separate UI state that
supports retry/permission guidance when current location is unavailable.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 8e6e7048-724f-4932-8c52-6160fd1d4253
📒 Files selected for processing (4)
src/features/pin/components/PinListSheet.tsxsrc/features/pin/components/PinPlaceSearch.tsxsrc/features/pin/types.tssrc/pages/MapPage.tsx
GitHub Actions
Failure
This branch had an error being deployed
1 participant
변경 내용
placeId와 북마크 상태를 유지하도록 타입과 변환 로직을 보완했습니다.관련 이슈
Closes #165
변경 사항
테스트
브라우저에서 정상 동작 확인
기존 기능에 영향 없음 확인
npm run typechecknpm run lint -- --max-warnings=10(오류 0건, 기존 Fast Refresh 경고 2건)npm run format:checknpm run build스크린샷 (UI 변경시)
체크리스트
pnpm format)pnpm lint:fix)코드 품질 확인
PR 제출 전에 다음 명령어를 실행하여 코드 품질을 확인해주세요:
Summary by CodeRabbit