[2주차/Thunder] 워크북 제출합니다. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpark0506
approved these changes
Mar 31, 2025
Comment on lines
+12
to
+15
| <div className="study-container"> | ||
| <TodoList /> | ||
| <DoneList /> | ||
| </div> |
There was a problem hiding this comment.
이 부분도 ListContainer로 모듈로 분리해주시면 좋을 것 같습니다~
There was a problem hiding this comment.
파일 이름 컨벤션 통일 시켜주시면 좋을 것 같습니다! (ThemeProvider)
|
|
||
| export default function Navbar(): React.JSX.Element { | ||
| const { theme, toggleTheme } = useTheme(); | ||
| const isLightMode = theme === THEME.LIGHT; |
There was a problem hiding this comment.
이 부분 useTheme이 반납하는 결과물로 주어, 더욱 NavBar라는 컴포넌트에 좋은 코드를 작성할 수 있을 것 같습니다~ 한번 도전해보세요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 워크북 체크리스트
✅ 컨벤션 체크리스트
📌 주안점