Use b1 quantization for USearch
#2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested by @adolfogc (in unum-cloud/usearch#405) the USearch implementation should use `b1` instead of `i8` for binary representations.
|
Hello! Looks good to me, I trust the expert on this one! Also, keep up the good work, and apologies that the NLTK StringZilla work hasn't moved forward yet - I don't really have time for that project anymore sadly.
|
Haha, I wouldn't - let's check that CI passes, if you have some 😅 As for NLTK, I'm prepping more improvements for StringZilla with more incoming contributors. NLTK still seems like a good place to apply those optimizations, so if you'd know someone who can validate the suggestions - happy to connect 🤗 |
|
I'm afraid I don't have CI over the semantic search examples 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @adolfogc (in unum-cloud/usearch#405) the USearch implementation should use
b1instead ofi8for binary representations.