Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAF-299: Investigate date format #236

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Rhodine-orleans-lindsay
Copy link
Contributor

@Rhodine-orleans-lindsay Rhodine-orleans-lindsay commented Aug 7, 2024

What?

  • Investigate date format

Why?

  • 'Date received' field in IMS showing incorrect date on submission

How?

  • added 0 in front of single digit minutes for time field
  • wrote fields in same case as set in IMS for dtborec and tmborec to avoid discrepencies.
  • set date format to en-GB to display date as 'dd/mm/yyyy' instead of 'mm/dd/yyyy'

Testing?

-all tests passing locally, tested on branch

Screenshots (optional)

Anything Else? (optional)

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant)
  • I have created a JIRA number for my branch
  • I have created a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/
    here is an example commit
  • Ensure drone builds are green especially tests
  • I will squash the commits before merging

- update ims-resolver image
- update yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant