feat(FN-3163): create new dtfs customer in sf feature branch #3892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
November 5, 2024 09:04
natdeanlewissoftwire
changed the title
natdeanlewissoftwire
changed the base branch from
main
to
feat/FN-3163/create-new-dtfs-customers-in-sf
natdeanlewissoftwire
temporarily deployed
to
dev
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
dev
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
dev
GitHub Actions
Inactive
added 2 commits
November 5, 2024 09:40
| @@ -820,13 +821,35 @@ const getPartyDbInfo = async ({ companyRegNo }) => { | |||
| url: `${EXTERNAL_API_URL}/party-db/${encodeURIComponent(companyRegNo)}`, | |||
| headers: headers.external, | |||
| }); | |||
| return response.data; | |||
| return AUTOMATIC_SF_CUSTOMER_CREATION_ENABLED ? { status: 200, data: response.data } : response.data; | |||
There was a problem hiding this comment.
The response needs a status (following the pattern elsewhere in dtfs) so that we can distinguish between a 404 and an actual failure when querying SF - we don't want to create customers unless we definitely have a 404
| @@ -60,7 +77,7 @@ const addPartyUrns = async (deal, auditDetails) => { | |||
| ...deal.tfm, | |||
| parties: { | |||
| exporter: { | |||
| partyUrn: await getPartyUrn({ companyRegNo: deal.exporter.companiesHouseRegistrationNumber }), | |||
| partyUrn: await getPartyUrn({ companyRegNo: deal.exporter.companiesHouseRegistrationNumber, companyName: deal.exporter.companyName }), | |||
There was a problem hiding this comment.
I've not flagged this additional input as that seems unnecessarily fiddly, let me know if I should!
There was a problem hiding this comment.
What do you mean by flagged please?
There was a problem hiding this comment.
Ah sorry that was confusing of me - I mean I've added an extra parameter to this function but it's not behind a feature flag, is that okay?
| @@ -21,7 +21,9 @@ export const lookup = async (req: Request, res: Response) => { | |||
|
|
|||
| const response: { status: number; data: unknown } = await axios({ | |||
| method: 'get', | |||
| url: `${APIM_MDM_URL}customers?companyReg=${companyReg}`, | |||
| url: AUTOMATIC_SF_CUSTOMER_CREATION_ENABLED | |||
| ? `${APIM_MDM_URL}customers/direct?companyRegistrationNumber=${companyReg}` | |||
There was a problem hiding this comment.
This uses the new direct SF api in MDM, old route is Informatica
There was a problem hiding this comment.
Could we call this route customers/salesforce rather than customers/direct, makes it a little clearer/less tied to the fact that an endpoint already exists
There was a problem hiding this comment.
Sure, I agree /salesforce is slightly clearer, will update my MDM work to match also
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
had a problem deploying
to
dev
GitHub Actions
Error
natdeanlewissoftwire
force-pushed
the
feat/FN-3163/create-new-dtfs-customer-in-sf-feature
branch
2 times, most recently
from
40ddede
to
ca987fb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
As part of the CCM project, if a customer does exist in Salesforce, we are automatically creating it rather than relying on the manual process currently undertaken by Business Support Group. This change sends a request to a new createParty endpoint that will be merged in to the MDM codebase.
Tech docs of the full process are available here
Resolution ✔️
Feature flagged for now:
If the customer lookup fails, send a creation request to MDM.
Miscellaneous ➕
We also replace the current GET customer in SF (that uses Informatica) with a new one that goes direct (hence the new url with /direct/ in) via the SF API.