fix(framework): apply theme after every theme props registration #6718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pskelin
reviewed
Mar 17, 2023
packages/base/src/Boot.ts
Outdated
| if (!booted) { | ||
| return; | ||
| } | ||
| applyTheme(getTheme()); |
Contributor
There was a problem hiding this comment.
may be we should check if the theme registered is the one that will be applied getTheme. there is no need to call applyTheme if the registered theme won't be applied.
Contributor
Author
There was a problem hiding this comment.
Agree, check is added with the commit chore: address review comments
pskelin
approved these changes
Mar 17, 2023
NHristov-sap
pushed a commit
that referenced
this pull request
May 4, 2023
There are use-cases when the framework boots, but the theme has not been registered and applied. And, currently the framework won't apply a theme after boot finishes. With this PR the framework will apply theme properties always when theme registration occurs. when the theme properties are registered before boot, an event will be fired, notifying for the theme registration, but as the boot did not finish, the event will be disregarded and the theme will be applied as usual. when the theme properties are being registered after boot, an event will be fired, notifying for the theme registration and the registered styles will be applied. Fixes: #6666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are use-cases when the framework boots, but the theme has not been registered and applied.
And, currently the framework won't apply a theme after boot finishes.
With this PR the framework will apply theme properties always when theme registration occurs.
Fixes: #6666