fix(ui5-button): move button type text from aria-label to aria-description #12474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption When a button has design property (like Emphasized, Negative), the type text should be in aria-description instead of aria-label for better semantic separation. Updated tests to verify the new behavior. Fixes #12413
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-12474--ui5-webcomponents.netlify.app |
Collaborator
|
🎉 This PR is included in version v2.16.0-rc.2 🎉 The release is available on v2.16.0-rc.2 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Moved button type text (like "Emphasized", "Negative", etc.) from aria-label to aria-description attribute for better semantic accessibility.
Why
Button type information should be supplementary description rather than part of the primary label. This provides cleaner aria-label values while maintaining accessibility information in the appropriate attribute.
What's Fixed
ariaLabelTextgetter to exclude button type textariaDescriptionTextgetter to include button type text alongside accessibleDescriptionFixes #12413