fix(ui5-button, ui5-toggle-button): fire event with correct type #11563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didip1000
reviewed
Jun 4, 2025
didip1000
approved these changes
Jun 6, 2025
nnaydenow
changed the title
Collaborator
|
🎉 This PR is included in version v2.12.0-rc.0 🎉 The release is available on v2.12.0-rc.0 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ui5-buttoncomponent currently has a click event listener attached to its root element. This listener prevents the native click event from propagating and instead triggers a custom event.However, there's an issue: when the
ui5-buttonhas a visible border defined on the custom element, clicking that border can trigger a native click event. This happens because only the root element inside the Shadow DOM is observed, not the host element itself.This PR resolves the issue by adding a click event handler to the host element as well, ensuring consistent event behavior regardless of where on the button the user clicks.
Issue is introduced with: #11318
Fixes: #11556