chore(SF-0.131): downport consolidates API of ObjectPage and DynamicPage #1848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lways interactive and won't expand the header (#1825)
Lukas742
changed the title
MarcusNotheis
requested changes
Jul 21, 2021
MarcusNotheis
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: DynamicPageHeader: children are no longer displayed as flex items to support other display types like grid. To align children you now need to add the container (like FlexBox) and CSS yourself.
BREAKING CHANGE: DynamicPageTitle: subHeading has been renamed. Please use subheading instead.
BREAKING CHANGE: DynamicPage: header has been renamed. Please use headerContent instead.
BREAKING CHANGE: DynamicPage: title has been renamed. Please use headerTitle instead.
BREAKING CHANGE: ObjectPage: title has been renamed to headerTitle and is now defining the upper, static, title section of the ObjectPage. It expects to receive the DynamicPageTitle component.
BREAKING CHANGE: ObjectPage: noHeader has been removed. It is now sufficient not to set headerTitle and header to achieve the same behavior.
BREAKING CHANGE: ObjectPage: title, subTitle, headerActions, breadcrumbs and keyInfos should now be passed to the corresponding DynamicPageTitle props.
BREAKING CHANGE: ObjectPageSection: title and titleUppercase has been renamed. Please use heading and headingUppercase instead.
BREAKING CHANGE: ObjectPageSubSection: title has been renamed. Please use heading instead.
BREAKING CHANGE: getScrollBarWidth has been removed.