Skip to content

Conversation

@flovogt
Copy link
Member

@flovogt flovogt commented May 21, 2024

Up until UI5 Tooling v3, the bundle option "usePredefineCalls" defaults to "false" and has to be activated explicitly in a custom bundle configuration.
For default bundles, such as Component-preload or self-contained bundle (sap-ui-custom.js), there is no way to use the option apart from re-defining the whole bundle via custom bundle definition.

With UI5 Tooling v4 bundles are generated with the usage sap.ui.predefine calls instead of the former default function wrapper. This leads to smaller bundle sizes and less overhead at runtime.

As the option only affects the internal handling of bundling without affecting the actual users,
the option is removed completely, instead of just changing the default value of the option.

Implementation covered in SAP/ui5-builder#1021.

JIRA: CPOUI5FOUNDATION-760

Copy link
Member

@d3xter666 d3xter666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flovogt flovogt requested a review from RandomByte May 27, 2024 13:16
flovogt added a commit to SAP/ui5-builder that referenced this pull request May 28, 2024
…on wrappers (#1021)

Up until UI5 Tooling v3, the bundle option "usePredefineCalls" defaults
to "false" and has to be activated explicitly in a custom bundle
configuration.
For default bundles, such as Component-preload or self-contained bundle
(sap-ui-custom.js), there is no way to use the option apart from
re-defining the whole bundle via custom bundle definition.

With UI5 Tooling v4 bundles are generated with the usage
sap.ui.predefine calls instead of the former default function wrapper.
This leads to smaller bundle sizes and less overhead at runtime.

As the option only affects the internal handling of bundling without
affecting the actual users,
the option is removed completely, instead of just changing the default
value of the option.

Documentation update covered in
UI5/cli#957.

JIRA: CPOUI5FOUNDATION-760

BREAKING CHANGE:
Created bundles use sap.ui.predefine instead function wrappers. For
projects this is a compatible change. Only the produced bundle content
changes.
@flovogt flovogt merged commit b4f4d93 into main May 28, 2024
@flovogt flovogt deleted the remove-usePredefineCalls-option branch May 28, 2024 12:26
d3xter666 pushed a commit that referenced this pull request Sep 24, 2025
…nstead function wrappers (#1021)

Up until UI5 Tooling v3, the bundle option "usePredefineCalls" defaults
to "false" and has to be activated explicitly in a custom bundle
configuration.
For default bundles, such as Component-preload or self-contained bundle
(sap-ui-custom.js), there is no way to use the option apart from
re-defining the whole bundle via custom bundle definition.

With UI5 Tooling v4 bundles are generated with the usage
sap.ui.predefine calls instead of the former default function wrapper.
This leads to smaller bundle sizes and less overhead at runtime.

As the option only affects the internal handling of bundling without
affecting the actual users,
the option is removed completely, instead of just changing the default
value of the option.

Documentation update covered in
#957.

JIRA: CPOUI5FOUNDATION-760

BREAKING CHANGE:
Created bundles use sap.ui.predefine instead function wrappers. For
projects this is a compatible change. Only the produced bundle content
changes.
d3xter666 pushed a commit that referenced this pull request Sep 25, 2025
…ad function wrappers (SAP/ui5-builder#1021)

Up until UI5 Tooling v3, the bundle option "usePredefineCalls" defaults
to "false" and has to be activated explicitly in a custom bundle
configuration.
For default bundles, such as Component-preload or self-contained bundle
(sap-ui-custom.js), there is no way to use the option apart from
re-defining the whole bundle via custom bundle definition.

With UI5 Tooling v4 bundles are generated with the usage
sap.ui.predefine calls instead of the former default function wrapper.
This leads to smaller bundle sizes and less overhead at runtime.

As the option only affects the internal handling of bundling without
affecting the actual users,
the option is removed completely, instead of just changing the default
value of the option.

Documentation update covered in
#957.

JIRA: CPOUI5FOUNDATION-760

BREAKING CHANGE:
Created bundles use sap.ui.predefine instead function wrappers. For
projects this is a compatible change. Only the produced bundle content
changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants