[0.1.dev9] Backdoor to add weights and interaction terms for MNL estimation #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a backdoor to the
LargeMultinomialLogitStep
template so that users can pass their ownMergedChoiceTable
for model estimation.The objective is to let people test out the new functionality in ChoiceModels PR #37 (sampling weights, interaction terms) before it's fully integrated into the templates.
Full integration will take a little while because we need to set up UrbanSim data structures and usage guidelines for 2d weights and interaction terms.
Usage
See this notebook for a demonstration: Interaction-and-sampling-demo-v1.ipynb
Other changes
Separately, this PR also formalizes the utilities for version comparison that we use to make sure saved model steps are recent enough to be loaded into the current version of ModelManager.
These new utilities even have unit tests! 🎉
Versioning
LargeMultinomialLogitStep
version incremented to 0.1.dev2