feat: implement MQTT publishing for lap data in LapController and SolarMQTTClient#273
Merged
dastine0308 merged 2 commits intomainfrom Jan 31, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 WalkthroughWalkthroughAdds MQTT lap-data publishing: a new topic and publish method in the MQTT client, and an MQTT publish step in the LapController's handleLapData flow before database insertion. Changes
Sequence DiagramsequenceDiagram
participant LapController as LapController
participant MQTTClient as SolarMQTTClient
participant Broker as MQTT_Broker
participant DB as DynamoDB
LapController->>MQTTClient: publishLapData(lapdata)
MQTTClient->>MQTTClient: JSON.stringify(lapdata)
MQTTClient->>Broker: publish to "lapdata" topic
Broker-->>MQTTClient: ack
MQTTClient-->>LapController: return
LapController->>DB: insert lap data
DB-->>LapController: ack
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
promatty
reviewed
Jan 31, 2026
packages/server/src/datasources/SolarMQTTClient/SolarMQTTClient.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.