Skip to content

Conversation

@skand088
Copy link
Contributor

No description provided.

@skand088 skand088 requested a review from a team as a code owner March 27, 2025 22:04
@vercel
Copy link

vercel bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helios-telemetry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2025 7:09pm

Copy link
Member

@burtonjong burtonjong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sucks

Copy link
Member

@promatty promatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the circle should be even smaller. When I send a packet with GpsLatitude: 37.004857904, GpsLongitude: -86.363013541, the car shows it is just at the edge of the circle, but a lap isn't completed (since no lap completion notification pops up).

Screenshot 2025-04-03 at 4 45 24 PM

@promatty
Copy link
Member

promatty commented Apr 3, 2025

fyi, GpsLatitude: 37.004757904, GpsLongitude: -86.363013541, also doesn't count as a lap yet.
Screenshot 2025-04-03 at 4 50 26 PM

@skand088 skand088 force-pushed the TEL-240-create-radius-around-finish-line branch from 2ebcf42 to 53a7405 Compare April 12, 2025 19:31
@kr1s-r kr1s-r mentioned this pull request May 3, 2025
@skand088 skand088 marked this pull request as draft May 10, 2025 16:55
@skand088 skand088 force-pushed the TEL-240-create-radius-around-finish-line branch from 53a7405 to 9342b69 Compare May 17, 2025 16:03
@skand088 skand088 marked this pull request as ready for review May 17, 2025 18:07
@skand088
Copy link
Contributor Author

CAN SOMEONE PLS TEST THIS 4 ME MY LAPTOP CANT HANDLE THE SMOKE!!!!

add these coords to LapController.tsx as finish line

public finishLineLocation: Coords = { lat: 37.004657904, long: -86.363013541, // coords from grand race track };

and in MQTT webserver, test the same coords by hardcoding them into utils.ts

GpsLatitude: 37.004657904, GpsLongitude: -86.363013541,

and then try these coords and make sure that all of them trigger the toast message in the bottom right on FULLSCREEN MAP MODE and that the car still has some part of it in the red radius (on full zoom, dont zoom out).

GpsLatitude: 37.004657903, GpsLongitude: -86.363013540,
GpsLatitude: 37.004657905, GpsLongitude: -86.363013542,

@skand088 skand088 requested a review from promatty May 24, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants