Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix brokenness with nbclassic override. #6

Closed
wants to merge 2 commits into from
Closed

Conversation

vwbusguy
Copy link
Contributor

Please wait to see if passes before merging on this one, Brian :-)

@ParadoxGuitarist
Copy link
Contributor

This might not be you:
image

@ParadoxGuitarist
Copy link
Contributor

Per the logs, looks like we might need pip install notebook

@vwbusguy
Copy link
Contributor Author

vwbusguy commented Sep 22, 2023

ipython-contrib/jupyter_contrib_nbextensions#1647

Jupyter-contrib/jupyter_nbextensions_configurator#165

These were ported over from a legacy image. At some point might be worth seeing what is still needed here.

It looks like there's a PR that might remedy this that's still waiting to be reviewed: Jupyter-contrib/jupyter_nbextensions_configurator#166

@ParadoxGuitarist
Copy link
Contributor

I'm not sure how they're missing notebook being installed. It's possible they're looking in an old path.

@vwbusguy
Copy link
Contributor Author

Pretty much. Instead of "notebook", it needs to look to server now: https://github.com/Jupyter-contrib/jupyter_nbextensions_configurator/pull/166/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants