NOP-57 - Moved Script and Inscription fields (#1193)

UCLALibrary · Feb 25, 2025 · bf523bf · bf523bf
1 parent 9f5cbb9
commit bf523bf
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 10 deletions.
diff --git a/config/metadata/item_overview_metadata.yml b/config/metadata/item_overview_metadata.yml
@@ -47,10 +47,9 @@ edition_ssm: 'Edition'
 
 # Other
 human_readable_language_tesim: 'Language'
+script_tesim: 'Script'
 member_of_collections_ssim: 'Collection'
 series_tesim: 'Series'
-inscription_tesim: 'Inscription'
-script_tesim: 'Script'
 # dlcs_collection_name_tesim: 'Collection (native)'
 
 associated_name_tesim: 'Associated name'

diff --git a/config/metadata/note_metadata.yml b/config/metadata/note_metadata.yml
@@ -1,6 +1,7 @@
 summary_tesim: 'Summary'
 description_tesim: 'Description'
 caption_tesim: 'Caption'
+inscription_tesim: 'Inscription'
 contents_note_tesim: 'Contents note'
 colophon_tesim: 'Colophon'
 history_tesim: 'History'

diff --git a/spec/presenters/ursus/item_overview_metadata_presenter_spec.rb b/spec/presenters/ursus/item_overview_metadata_presenter_spec.rb
@@ -27,7 +27,6 @@
       'human_readable_language_tesim' => 'Language',
       'illuminator_tesim' => 'Illuminator',
       'illustrator_tesim' => 'Illustrator',
-      'inscription_tesim' => 'Inscription',
       'interviewee_tesim' => 'Interviewee',
       'interviewer_tesim' => 'Interviewer',
       'librettist_tesim' => 'Librettist',
@@ -160,10 +159,6 @@
         expect(config['illustrator_tesim'].to_s).to eq('Illustrator')
       end
 
-      it 'returns the Inscription key' do
-        expect(config['inscription_tesim'].to_s).to eq('Inscription')
-      end
-
       it 'returns the Interviewee Key' do
         expect(config['interviewee_tesim'].to_s).to eq('Interviewee')
       end
@@ -258,7 +253,7 @@
       let(:missing) { presenter_object_missing_items.overview_terms.keys.length }
 
       it "returns existing keys" do
-        expect(all).to eq 50
+        expect(all).to eq 49
         expect(config.length).to eq all
       end
 

diff --git a/spec/presenters/ursus/note_metadata_presenter_spec.rb b/spec/presenters/ursus/note_metadata_presenter_spec.rb
@@ -17,7 +17,8 @@
       'resp_statement_tesim' => 'Statement of Responsibility',
       'citation_source_tesim' => 'References',
       'incipit_tesim' => 'Incipit',
-      'explicit_tesim' => 'Explicit'
+      'explicit_tesim' => 'Explicit',
+      'inscription_tesim' => 'Inscription'
     }
   end
   let(:solr_doc_missing_items) do
@@ -96,7 +97,7 @@
 
       it "returns existing keys" do
         expect(presenter_object.note_terms).to be_instance_of(Hash)
-        expect(all).to eq 14
+        expect(all).to eq 15
         expect(config.length).to eq all
       end