Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to Doxygen pages, and use doxygen as a CI check. #231

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

samcunliffe
Copy link
Member

@samcunliffe samcunliffe commented Feb 16, 2023

This PR is the first part of #230. It makes three changes:

  1. Adds README.md and CONTRIBUTING.md to the web pages (they appear in that order in the ToC followed by the developer docs 👍). Screenshot below, and live dev version over on my personal fork.
  2. Uses MacOS/homebrew to install and run Doxygen 1.9.6 which is much cooler 😎 than the version we were previously using in ubuntu (1.9.2 👎 ). Amongst other improvements: the cool version correctly renders the <details> HTML tags.
  3. Splits the Doxygen workflow into two steps: doxygen and publish. This has a couple of benefits...

In particular for the first step, when we've got everything documented, we can set Doxygen to fail when it encounters an undocumented warning. This would then fail the CI.

Too many words? Here's a screenshot...

Screenshot 2023-02-22 at 21 11 34

Next planned steps:

  • Introduce logos and a citation link.
  • Reword README and CONTRIBUTING to avoid duplication of information.
  • Turn the Doxygen warnings into GH Actions annotations(?)
  • Actually fix Doxygen warnings (there aren't too many of them) and turn Doxygen warnings → build errors.

@samcunliffe samcunliffe force-pushed the readme-and-contributing-into-main-page-230 branch from d6fa2c6 to 77febc9 Compare February 20, 2023 16:57
@samcunliffe samcunliffe changed the title Add README and CONTRIBUTING.md to the doxygen pages. Add to Doxygen pages, and use doxygen as a CI check. Feb 22, 2023
@samcunliffe samcunliffe added documentation Improvements or additions to documentation technical Technical and meta issues, not related to physics but infrastructure. review required A review approval is required before merging housekeeping Code cleanup labels Feb 22, 2023
@samcunliffe samcunliffe marked this pull request as ready for review February 22, 2023 21:36
README.md Show resolved Hide resolved
.github/workflows/doxygen-gh-pages.yml Show resolved Hide resolved
Comment on lines +3 to +8
# Generate the documentation on all merges to main, all pull requests, or by
# manual workflow dispatch. The Doxygen job can be used as a CI check that all
# functions are documented. The publish job only runs on new commits to the main
# branch and actually pushes the generated html to the gh-pages branch (which
# triggers a GitHub pages deployment). When things are a bit more stable, we can
# only publish the website on release tags.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

README.md Show resolved Hide resolved
@samcunliffe samcunliffe merged commit 290399b into main Feb 23, 2023
@willGraham01 willGraham01 deleted the readme-and-contributing-into-main-page-230 branch February 23, 2023 09:39
willGraham01 pushed a commit that referenced this pull request Mar 6, 2023
* Add README and CONTRIBUTING.md to the doxygen pages.

* Split workflow into two jobs. Fix README inclusion.

* Don't need that yet.

Remove the copy of images.
willGraham01 pushed a commit that referenced this pull request Mar 7, 2023
* Add README and CONTRIBUTING.md to the doxygen pages.

* Split workflow into two jobs. Fix README inclusion.

* Don't need that yet.

Remove the copy of images.
willGraham01 pushed a commit that referenced this pull request Mar 29, 2023
* Add README and CONTRIBUTING.md to the doxygen pages.

* Split workflow into two jobs. Fix README inclusion.

* Don't need that yet.

Remove the copy of images.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation housekeeping Code cleanup review required A review approval is required before merging technical Technical and meta issues, not related to physics but infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants