This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
Complete Issue #10 work and improved data structure #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefpiatek
reviewed
Oct 29, 2020
Comment on lines
+67
to
+82
| max_age = max([ person.age for person in my_group ]) | ||
| print('Maximum age = ' + str(max_age)) | ||
|
|
||
| # Average number of relations | ||
| mean_rels = np.mean([ len(person.relations.keys()) for person in my_group ]) | ||
| print('Mean number of relations = ' + str(mean_rels)) | ||
|
|
||
| # Maximum age for ppl with at least one relation | ||
| max_age_min1rel = max([ person.age for person in my_group if len(person.relations.keys()) >= 1 ]) | ||
| print('Maximum age of people with at least one relation = ' + str(max_age_min1rel)) | ||
|
|
||
| # Maximum age for ppl with at least one friend | ||
| max_age_min1friend = max([ person.age for person in my_group if 'friend' in person.relations.values() ]) | ||
| print('Maximim age of people with at least one friend = ' + str(max_age_min1friend)) | ||
|
|
||
| my_group_dict = { person.name : {'age' : person.age, 'job': person.job, 'relations' : person.relations_str()} for person in my_group } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Answers UCL-RITS/rse-classwork-2020#10
What?
Completed the work for Data structures and comprehension expressions Issue.
Why?
To learn!
How?
Improved data structed to make use of a class then used list comprehensions to complete tasks.