Use bcrypt with password_hash #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-j-smith
approved these changes
Jan 5, 2024
|
Yup, passlib looks abandoned to me - annoying that Ansible are still using it. |
drmatthews
added a commit
to UCL-MIRSG/ansible-collection-xnat
that referenced
this pull request
Jan 5, 2024
Changes: - Update variable names for the `firewalld` role in the molecule tests - Update some details in `galaxy.yml` After UCL-MIRSG/ansible-collection-infra#35 is merged I propose creating a new release of the `mirsg.infrastructure` collection (`1.3.0`) and pinning the version number in [meta/requirements.yml](https://github.com/UCL-MIRSG/ansible-collection-xnat/blob/33413301671dcca18388f13a91ec363c9ce07539/meta/requirements.yml#L10) in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
bcryptoption forpassword_hashThis has been done since
node_exporterexpects hashed password for basic authentication to be created withbrypt. I initially removed because the following appears when running themonitoring_clientrole:The play proceeds and
node_exporteris correctly installed. I tried pinningbcryptto4.0.1as suggested in pyca/bcrypt#684 but the traceback still appears. Withoutbcryptthenode_exporterservice fails to start.